]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
dm mpath: always free attached_handler_name in parse_path()
authorMartin Wilck <mwilck@suse.com>
Mon, 29 Apr 2019 09:48:15 +0000 (11:48 +0200)
committerMike Snitzer <snitzer@redhat.com>
Tue, 30 Apr 2019 20:51:30 +0000 (16:51 -0400)
commit940bc471780b004a5277c1931f52af363c2fc9da
treef32e4a2e09e7329d7ae3d966d521214a51907e56
parent8e890c1ab1b1e0f765cd8da82c4dee011698a5e8
dm mpath: always free attached_handler_name in parse_path()

Commit b592211c33f7 ("dm mpath: fix attached_handler_name leak and
dangling hw_handler_name pointer") fixed a memory leak for the case
where setup_scsi_dh() returns failure. But setup_scsi_dh may return
success and not "use" attached_handler_name if the
retain_attached_hwhandler flag is not set on the map. As setup_scsi_sh
properly "steals" the pointer by nullifying it, freeing it
unconditionally in parse_path() is safe.

Fixes: b592211c33f7 ("dm mpath: fix attached_handler_name leak and dangling hw_handler_name pointer")
Cc: stable@vger.kernel.org
Reported-by: Yufen Yu <yuyufen@huawei.com>
Signed-off-by: Martin Wilck <mwilck@suse.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
drivers/md/dm-mpath.c