]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
MIPS: Avoid accidental raw backtrace
authorJames Hogan <james.hogan@imgtec.com>
Thu, 29 Jun 2017 14:05:04 +0000 (15:05 +0100)
committerSeth Forshee <seth.forshee@canonical.com>
Wed, 5 Jul 2017 16:36:40 +0000 (11:36 -0500)
commit943c20e8e6356fe430ecc4e3ef5f540422bcab28
tree2d1844d2ff49e954a7eedaa43abb7bed9a83604a
parent95581bac460e5f8c10b91e7a90358691755c8ac1
MIPS: Avoid accidental raw backtrace

BugLink: http://bugs.launchpad.net/bugs/1702515
commit 854236363370995a609a10b03e35fd3dc5e9e4a1 upstream.

Since commit 81a76d7119f6 ("MIPS: Avoid using unwind_stack() with
usermode") show_backtrace() invokes the raw backtracer when
cp0_status & ST0_KSU indicates user mode to fix issues on EVA kernels
where user and kernel address spaces overlap.

However this is used by show_stack() which creates its own pt_regs on
the stack and leaves cp0_status uninitialised in most of the code paths.
This results in the non deterministic use of the raw back tracer
depending on the previous stack content.

show_stack() deals exclusively with kernel mode stacks anyway, so
explicitly initialise regs.cp0_status to KSU_KERNEL (i.e. 0) to ensure
we get a useful backtrace.

Fixes: 81a76d7119f6 ("MIPS: Avoid using unwind_stack() with usermode")
Signed-off-by: James Hogan <james.hogan@imgtec.com>
Cc: linux-mips@linux-mips.org
Patchwork: https://patchwork.linux-mips.org/patch/16656/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
arch/mips/kernel/traps.c