]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
platform/x86: asus-wireless: Fix uninitialized symbol usage
authorJoão Paulo Rechi Vita <jprvita@endlessm.com>
Fri, 29 Jun 2018 22:12:46 +0000 (15:12 -0700)
committerJuerg Haefliger <juergh@canonical.com>
Wed, 24 Jul 2019 01:51:40 +0000 (19:51 -0600)
commit949f194e69b1bdd2f15eaf7af8286b6c822a0f54
tree96e1f6acdfd81dc3aaf22190c1e42332514cc658
parenteeb2c29dfb629a67c7a4ddc5b05241f4a9e0af8b
platform/x86: asus-wireless: Fix uninitialized symbol usage

BugLink: https://bugs.launchpad.net/bugs/1836287
[ Upstream commit eca4c4e47eb0658ad251f0bff465e23c055377da ]

'ret' will not be initialized if acpi_evaluate_integer() returns through
an error path, so it should not be used in this case. This fixes the
following Smatch static analyser error:

 drivers/platform/x86/asus-wireless.c:76 asus_wireless_method() error:
                                                     uninitialized symbol 'ret'.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: João Paulo Rechi Vita <jprvita@endlessm.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/platform/x86/asus-wireless.c