]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
drm/dp_mst: Fix drm_dp_check_mstb_guid() return code
authorLyude Paul <lyude@redhat.com>
Fri, 6 Mar 2020 23:49:22 +0000 (18:49 -0500)
committerLyude Paul <lyude@redhat.com>
Tue, 10 Mar 2020 18:22:42 +0000 (14:22 -0400)
commit94b6ada401cbcf2e81f34ac7c5c4ca82154fd22e
tree5b43c7014010350f17ab7b8bd903257264a2f65e
parent4c0a9b62b3e36bc5b06c1a796e5d4d938d9c556a
drm/dp_mst: Fix drm_dp_check_mstb_guid() return code

We actually expect this to return a 0 on success, or negative error code
on failure. In order to do that, we check whether or not we managed to
write the whole GUID and then return 0 if so, otherwise return a
negative error code. Also, let's add an error message here so it's a
little more obvious when this fails in the middle of a link address
probe.

This should fix issues with certain MST hubs seemingly stopping for no
reason in the middle of the link address probe process.

Fixes: cb897542c6d2 ("drm/dp_mst: Fix W=1 warnings")
Cc: Benjamin Gaignard <benjamin.gaignard@st.com>
Cc: Sean Paul <sean@poorly.run>
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Lyude Paul <lyude@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200306234923.547873-3-lyude@redhat.com
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/drm_dp_mst_topology.c