]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
ARM: tegra: Restore DT ABI on Tegra124 Chromebooks
authorThierry Reding <treding@nvidia.com>
Mon, 11 Feb 2019 11:09:19 +0000 (12:09 +0100)
committerArnd Bergmann <arnd@arndb.de>
Wed, 20 Feb 2019 15:08:49 +0000 (16:08 +0100)
commit94d9b9337d09bdd27735005b3251d97ab29f7273
treeeee60eb6a5fa40453063f481f07eb9186bed6c53
parenta3b22b9f11d9fbc48b0291ea92259a5a810e9438
ARM: tegra: Restore DT ABI on Tegra124 Chromebooks

Commit 482997699ef0 ("ARM: tegra: Fix unit_address_vs_reg DTC warnings
for /memory") inadventently broke device tree ABI by adding a unit-
address to the "/memory" node because the device tree compiler flagged
the missing unit-address as a warning.

Tegra124 Chromebooks (a.k.a. Nyan) use a bootloader that relies on the
full name of the memory node in device tree being exactly "/memory". It
can be argued whether this was a good decision or not, and some other
bootloaders (such as U-Boot) do accept a unit-address in the name of the
node, but the device tree is an ABI and we can't break existing setups
just because the device tree compiler considers it bad practice to omit
the unit-address nowadays.

This partially reverts the offending commit and restores device tree ABI
compatibility.

Fixes: 482997699ef0 ("ARM: tegra: Fix unit_address_vs_reg DTC warnings for /memory")
Reported-by: Tristan Bastian <tristan-c.bastian@gmx.de>
Signed-off-by: Thierry Reding <treding@nvidia.com>
Tested-by: Tristan Bastian <tristan-c.bastian@gmx.de>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
arch/arm/boot/dts/tegra124-nyan.dtsi