]> git.proxmox.com Git - mirror_qemu.git/commit
hw/m68k/q800: Don't connect two qemu_irqs directly to the same input
authorPeter Maydell <peter.maydell@linaro.org>
Fri, 6 Nov 2020 23:51:08 +0000 (23:51 +0000)
committerLaurent Vivier <laurent@vivier.eu>
Sat, 12 Dec 2020 17:05:30 +0000 (18:05 +0100)
commit9526486164818f1c59a142dec8a1f09fbf77669c
tree7785400e4e3ba3fdfa1bed3e149ea6e8eefb82c9
parentad717e6da3852b5729217d7938eecdb81c546114
hw/m68k/q800: Don't connect two qemu_irqs directly to the same input

The q800 board code connects both of the IRQ outputs of the ESCC
to the same pic[3] qemu_irq. Connecting two qemu_irqs outputs directly
to the same input is not valid as it produces subtly wrong behaviour
(for instance if both the IRQ lines are high, and then one goes
low, the PIC input will see this as a high-to-low transition
even though the second IRQ line should still be holding it high).

This kind of wiring needs an explicitly created OR gate; add one.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20201106235109.7066-2-peter.maydell@linaro.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
hw/m68k/Kconfig
hw/m68k/q800.c