]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
btrfs: simplify return values in setup_nodes_for_search
authorNikolay Borisov <nborisov@suse.com>
Fri, 13 Nov 2020 07:29:40 +0000 (09:29 +0200)
committerDavid Sterba <dsterba@suse.com>
Tue, 8 Dec 2020 14:54:13 +0000 (15:54 +0100)
commit95b982de37473a99add60c9e68b12d54354f1da7
tree98a97506f2f95abebda62072dcb80e3fc28739b3
parentd5286a92ea76a124d6cfa1e261394da858125d99
btrfs: simplify return values in setup_nodes_for_search

The function is needlessly convoluted. Fix that by:

* removing redundant sret variable definition in both if arms

* replace the again/done labels with direct return statements, the
  function is short enough and doesn't do anything special upon exit

* remove BUG_ON on split_node returning a positive number - it can't
  happen as split_node returns either 0 or a negative error code.

Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/ctree.c