]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
agp: intel-agp: do not use PCI resources before pci_enable_device()
authorKulikov Vasiliy <segooon@gmail.com>
Tue, 3 Aug 2010 15:42:34 +0000 (19:42 +0400)
committerDave Airlie <airlied@redhat.com>
Thu, 5 Aug 2010 02:28:25 +0000 (12:28 +1000)
commit96576a9e1a0cdb8a43d3af5846be0948f52b4460
tree2a1a58c5862b3c790b36ce44867c9f5d1f758352
parent46cfc58a77de5fc8385ad87077f4dc14633e57a7
agp: intel-agp: do not use PCI resources before pci_enable_device()

IRQ and resource[] may not have correct values until
after PCI hotplug setup occurs at pci_enable_device() time.

The semantic match that finds this problem is as follows:

// <smpl>
@@
identifier x;
identifier request ~= "pci_request.*|pci_resource.*";
@@

(
* x->irq
|
* x->resource
|
* request(x, ...)
)
 ...
*pci_enable_device(x)
// </smpl>

Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
drivers/char/agp/intel-agp.c