]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
drm: require each CRTC to have a unique primary plane
authorSimon Ser <contact@emersion.fr>
Fri, 11 Dec 2020 18:46:34 +0000 (19:46 +0100)
committerSimon Ser <contact@emersion.fr>
Thu, 17 Dec 2020 16:03:42 +0000 (17:03 +0100)
commit96962e3de725f734b7f4671a21920b12cb2799c7
tree55155f862ef63b60ca40157679e92532c7505e70
parenta7ecf00346823c3434bf7d629ee0b2620de2d62c
drm: require each CRTC to have a unique primary plane

User-space expects to be able to pick a primary plane for each CRTC
exposed by the driver. Make sure this assumption holds in
drm_mode_config_validate.

Use the legacy drm_crtc.primary field to check this, because it's
simpler and we require drivers to set it anyways. Accumulate a set of
primary planes which are already used for a CRTC in a bitmask. Error out
if a primary plane is re-used.

v2: new patch

v3:
- Use u64 instead of __u64 (Jani)
- Use `unsigned int` instead of `unsigned` (Jani)

v4:
- Use u32 instead of u64 for plane mask (Ville)
- Use drm_plane_mask instead of BIT (Ville)
- Fix typos (Ville)

Signed-off-by: Simon Ser <contact@emersion.fr>
Reviewed-by: Daniel Vetter <daniel@ffwll.ch>
Acked-by: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: Pekka Paalanen <ppaalanen@gmail.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20201211184634.74534-4-contact@emersion.fr
drivers/gpu/drm/drm_mode_config.c
drivers/gpu/drm/drm_plane.c