]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
net: ethernet: ti: cpsw: add check for in-band mode setting with RGMII PHY interface
authorSZ Lin (林上智) <sz.lin@moxa.com>
Thu, 15 Mar 2018 16:56:01 +0000 (00:56 +0800)
committerThadeu Lima de Souza Cascardo <cascardo@canonical.com>
Mon, 2 Apr 2018 10:19:52 +0000 (07:19 -0300)
commit96c119b44316efa5bf2d0fe6853cfdc2e1b70961
tree1bfda5f3c089dbda55d5a44a0b54807bc48866a2
parent7756f8a222759397d400c8e1dd1e07b5d3f3988f
net: ethernet: ti: cpsw: add check for in-band mode setting with RGMII PHY interface

BugLink: http://bugs.launchpad.net/bugs/1760585
[ Upstream commit f9db50691db4a7d860fce985f080bb3fc23a7ede ]

According to AM335x TRM[1] 14.3.6.2, AM437x TRM[2] 15.3.6.2 and
DRA7 TRM[3] 24.11.4.8.7.3.3, in-band mode in EXT_EN(bit18) register is only
available when PHY is configured in RGMII mode with 10Mbps speed. It will
cause some networking issues without RGMII mode, such as carrier sense
errors and low throughput. TI also mentioned this issue in their forum[4].

This patch adds the check mechanism for PHY interface with RGMII interface
type, the in-band mode can only be set in RGMII mode with 10Mbps speed.

References:
[1]: https://www.ti.com/lit/ug/spruh73p/spruh73p.pdf
[2]: http://www.ti.com/lit/ug/spruhl7h/spruhl7h.pdf
[3]: http://www.ti.com/lit/ug/spruic2b/spruic2b.pdf
[4]: https://e2e.ti.com/support/arm/sitara_arm/f/791/p/640765/2392155

Suggested-by: Holsety Chen (陳憲輝) <Holsety.Chen@moxa.com>
Signed-off-by: SZ Lin (林上智) <sz.lin@moxa.com>
Signed-off-by: Schuyler Patton <spatton@ti.com>
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
drivers/net/ethernet/ti/cpsw.c