]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
tty: improve tty_insert_flip_char() slow path
authorArnd Bergmann <arnd@arndb.de>
Tue, 20 Jun 2017 21:10:42 +0000 (23:10 +0200)
committerSeth Forshee <seth.forshee@canonical.com>
Thu, 28 Sep 2017 14:30:58 +0000 (10:30 -0400)
commit97a97d6610cadd37397e31f3d531da97d8437739
treefa56a44e647a95bc0c6c09487c840b3ed0141aa9
parent14f73def55545a47b484866c9cc31d8d76da5396
tty: improve tty_insert_flip_char() slow path

BugLink: http://bugs.launchpad.net/bugs/1720154
commit 065ea0a7afd64d6cf3464bdd1d8cd227527e2045 upstream.

While working on improving the fast path of tty_insert_flip_char(),
I noticed that by calling tty_buffer_request_room(), we needlessly
move to the separate flag buffer mode for the tty, even when all
characters use TTY_NORMAL as the flag.

This changes the code to call __tty_buffer_request_room() with the
correct flag, which will then allocate a regular buffer when it rounds
out of space but no special flags have been used. I'm guessing that
this is the behavior that Peter Hurley intended when he introduced
the compacted flip buffers.

Fixes: acc0f67f307f ("tty: Halve flip buffer GFP_ATOMIC memory consumption")
Cc: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
drivers/tty/tty_buffer.c