]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
bnxt: make sure we return pages to the pool
authorJakub Kicinski <kuba@kernel.org>
Wed, 11 Jan 2023 04:25:47 +0000 (20:25 -0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 12 Jan 2023 04:48:37 +0000 (20:48 -0800)
commit97f5e03a4a27d27ee4fed0cdb1658c81cf2784db
treeb8de25244f6d516616edca038c333e30b63817e6
parentae9f29fdfd827ad06c1ae8155c042245a9d00757
bnxt: make sure we return pages to the pool

Before the commit under Fixes the page would have been released
from the pool before the napi_alloc_skb() call, so normal page
freeing was fine (released page == no longer in the pool).

After the change we just mark the page for recycling so it's still
in the pool if the skb alloc fails, we need to recycle.

Same commit added the same bug in the new bnxt_rx_multi_page_skb().

Fixes: 1dc4c557bfed ("bnxt: adding bnxt_xdp_build_skb to build skb from multibuffer xdp_buff")
Reviewed-by: Andy Gospodarek <gospo@broadcom.com>
Link: https://lore.kernel.org/r/20230111042547.987749-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/broadcom/bnxt/bnxt.c