]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
drm/i915: Fix CSR MMIO address check
authorTakashi Iwai <tiwai@suse.de>
Wed, 9 Sep 2015 14:52:09 +0000 (16:52 +0200)
committerJani Nikula <jani.nikula@intel.com>
Thu, 10 Sep 2015 07:32:48 +0000 (10:32 +0300)
commit982b0b2dd590c00f089fc6fe915bd0cb302a7f5c
treed29dd8b0f7698cd9dddea73b261dd14aba81d61d
parentacd29f7b22262d9e848393b9b6ae13eb42d22514
drm/i915: Fix CSR MMIO address check

Fix a wrong logical AND (&&) used for the range check of CSR MMIO.

Spotted nicely by gcc -Wlogical-op flag:
  drivers/gpu/drm/i915/intel_csr.c: In function ‘finish_csr_load’:
  drivers/gpu/drm/i915/intel_csr.c:353:41: warning: logical ‘and’ of mutually exclusive tests is always false [-Wlogical-op]

Fixes: eb805623d8b1 ('drm/i915/skl: Add support to load SKL CSR firmware.')
Cc: <stable@vger.kernel.org> # v4.2
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Animesh Manna <animesh.manna@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/intel_csr.c