]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
serial: core: mark port as initialized after successful IRQ change
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>
Thu, 11 Jan 2018 17:57:26 +0000 (18:57 +0100)
committerSeth Forshee <seth.forshee@canonical.com>
Thu, 8 Feb 2018 03:08:37 +0000 (21:08 -0600)
commit98f7f4bed05c8ab678669d0838b5f5a4db935220
tree6b2b727c06fb557f8320a0056757b70cdf1b8c7f
parenta57b802c10fd409f65d40dbe23494ce951cb4f01
serial: core: mark port as initialized after successful IRQ change

BugLink: http://bugs.launchpad.net/bugs/1748072
commit 44117a1d1732c513875d5a163f10d9adbe866c08 upstream.

setserial changes the IRQ via uart_set_info(). It invokes
uart_shutdown() which free the current used IRQ and clear
TTY_PORT_INITIALIZED. It will then update the IRQ number and invoke
uart_startup() before returning to the caller leaving
TTY_PORT_INITIALIZED cleared.

The next open will crash with
|  list_add double add: new=ffffffff839fcc98, prev=ffffffff839fcc98, next=ffffffff839fcc98.
since the close from the IOCTL won't free the IRQ (and clean the list)
due to the TTY_PORT_INITIALIZED check in uart_shutdown().

There is same pattern in uart_do_autoconfig() and I *think* it also
needs to set TTY_PORT_INITIALIZED there.
Is there a reason why uart_startup() does not set the flag by itself
after the IRQ has been acquired (since it is cleared in uart_shutdown)?

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
drivers/tty/serial/serial_core.c