]> git.proxmox.com Git - mirror_qemu.git/commit
maint: Tell git that *.py files should use python diff hunks
authorEric Blake <eblake@redhat.com>
Mon, 15 Feb 2021 22:25:24 +0000 (16:25 -0600)
committerCleber Rosa <crosa@redhat.com>
Tue, 16 Feb 2021 03:13:34 +0000 (22:13 -0500)
commit991e80911ed131f1785bd6015647180fed4dd95f
treeb616c9b2ecdb2fe58068100d024ee4d8cf0d6547
parentcdcc50bf6e05749478d93b42dd4b13114f416b5a
maint: Tell git that *.py files should use python diff hunks

Git's default hunk pattern recognizer favors the C language, but it
also includes several built-in diff styles that give saner results in
other languages.  In particular, telling git to treat all .py files as
python changes the beginning of diff hunks as follows:

|  --- a/python/qemu/machine.py
|  +++ b/python/qemu/machine.py
| -@@ -337,12 +337,12 @@ class QEMUMachine:
| +@@ -337,12 +337,12 @@ def _post_shutdown(self) -> None:
|               self._qmp.close()

which makes it much easier to tell what function a patch is touching,
rather than a non-descript listing of what class contains the changes.

Sadly, our python files that don't use .py suffix (such as numerous
iotests) do not benefit from this glob.

Reported-by: John Snow <jsnow@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20210215222524.1820223-1-eblake@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
Signed-off-by: Cleber Rosa <crosa@redhat.com>
.gitattributes