]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
Input: pm8xxx-vib - fix handling of separate enable register
authorStephan Gerhold <stephan@gerhold.net>
Fri, 17 Jan 2020 21:40:36 +0000 (13:40 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Tue, 21 Jan 2020 04:40:04 +0000 (20:40 -0800)
commit996d5d5f89a558a3608a46e73ccd1b99f1b1d058
tree9e17275b03fc5c10f76cbcc89eb867131f00e921
parentba9a103f40fc4a3ec7558ec9b0b97d4f92034249
Input: pm8xxx-vib - fix handling of separate enable register

Setting the vibrator enable_mask is not implemented correctly:

For regmap_update_bits(map, reg, mask, val) we give in either
regs->enable_mask or 0 (= no-op) as mask and "val" as value.
But "val" actually refers to the vibrator voltage control register,
which has nothing to do with the enable_mask.

So we usually end up doing nothing when we really wanted
to enable the vibrator.

We want to set or clear the enable_mask (to enable/disable the vibrator).
Therefore, change the call to always modify the enable_mask
and set the bits only if we want to enable the vibrator.

Fixes: d4c7c5c96c92 ("Input: pm8xxx-vib - handle separate enable register")
Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
Link: https://lore.kernel.org/r/20200114183442.45720-1-stephan@gerhold.net
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/misc/pm8xxx-vibrator.c