]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
net: axienet: Fix TX ring slot available check
authorRobert Hancock <robert.hancock@calian.com>
Tue, 18 Jan 2022 21:41:29 +0000 (15:41 -0600)
committerDavid S. Miller <davem@davemloft.net>
Wed, 19 Jan 2022 11:29:14 +0000 (11:29 +0000)
commit996defd7f8b5dafc1d480b7585c7c62437f80c3c
tree294b8b5cd72d1e18d73689817b12616ca1ba3fd4
parent70f5817deddbc6ef3faa35841cab83c280cc653a
net: axienet: Fix TX ring slot available check

The check for whether a TX ring slot was available was incorrect,
since a slot which had been loaded with transmit data but the device had
not started transmitting would be treated as available, potentially
causing non-transmitted slots to be overwritten. The control field in
the descriptor should be checked, rather than the status field (which may
only be updated when the device completes the entry).

Fixes: 8a3b7a252dca9 ("drivers/net/ethernet/xilinx: added Xilinx AXI Ethernet driver")
Signed-off-by: Robert Hancock <robert.hancock@calian.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/xilinx/xilinx_axienet_main.c