]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
tracing: Have event format check not flag %p* on __get_dynamic_array()
authorSteven Rostedt (Google) <rostedt@goodmis.org>
Thu, 7 Apr 2022 18:56:32 +0000 (14:56 -0400)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 16 Sep 2022 08:53:32 +0000 (10:53 +0200)
commit99876cf4a3383702241cd3fb55c3492cdcec3c4c
treec9a607b59457b8a96c07e575772ffaf1a1a607a5
parent91c5d8b3e9912c495159e6dd29f90f4a441fe0a7
tracing: Have event format check not flag %p* on __get_dynamic_array()

BugLink: https://bugs.launchpad.net/bugs/1988479
[ Upstream commit 499f12168aebd6da8fa32c9b7d6203ca9b5eb88d ]

The print fmt check against trace events to make sure that the format does
not use pointers that may be freed from the time of the trace to the time
the event is read, gives a false positive on %pISpc when reading data that
was saved in __get_dynamic_array() when it is perfectly fine to do so, as
the data being read is on the ring buffer.

Link: https://lore.kernel.org/all/20220407144524.2a592ed6@canb.auug.org.au/
Cc: stable@vger.kernel.org
Fixes: 5013f454a352c ("tracing: Add check of trace event print fmts for dereferencing pointers")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
kernel/trace/trace_events.c