]> git.proxmox.com Git - mirror_qemu.git/commit
ui/curses.c: Clean up nextchr logic
authorPeter Maydell <peter.maydell@linaro.org>
Thu, 11 Aug 2016 14:23:27 +0000 (15:23 +0100)
committerGerd Hoffmann <kraxel@redhat.com>
Tue, 13 Sep 2016 06:01:39 +0000 (08:01 +0200)
commit99a9ef44dca4be93f60c38d83a79eaaf8c56548a
tree4eb268a541e8609891f32e6365f9cf1046328cad
parentbba4e1b591531c087fce4ae501dc1ca299d8fb42
ui/curses.c: Clean up nextchr logic

Coverity identifies that at the top of the while(1) loop
in curses_refresh() the variable nextchr is always ERR,
and so the else case of the first if() is dead code.
Remove this dead code, and narrow the scope of the
nextchr variable to the place where it's used.

(This confused logic has been present since the curses
code was added to QEMU in 2008.)

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 1470925407-23850-3-git-send-email-peter.maydell@linaro.org
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
ui/curses.c