]> git.proxmox.com Git - mirror_qemu.git/commit
ui: mix misleading comments & return types of VNC I/O helper methods
authorDaniel P. Berrange <berrange@redhat.com>
Mon, 18 Dec 2017 19:12:28 +0000 (19:12 +0000)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Tue, 13 Feb 2018 00:34:38 +0000 (18:34 -0600)
commit9a26ca6b9422e4bb68baec8ad1cf4c3ce6d1db98
treefd17d39ecaa8020ad68ab283cd8cf04229e7a887
parent172f4e5a31afd17d891ab4e19fc4aa7b7164d2c3
ui: mix misleading comments & return types of VNC I/O helper methods

While the QIOChannel APIs for reading/writing data return ssize_t, with negative
value indicating an error, the VNC code passes this return value through the
vnc_client_io_error() method. This detects the error condition, disconnects the
client and returns 0 to indicate error. Thus all the VNC helper methods should
return size_t (unsigned), and misleading comments which refer to the possibility
of negative return values need fixing.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-id: 20171218191228.31018-14-berrange@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
(cherry picked from commit 30b80fd5269257f55203b7072c505b4ebaab5115)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
ui/vnc-auth-sasl.c
ui/vnc-auth-sasl.h
ui/vnc.c
ui/vnc.h