]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
ixgbe: xsk: change !netif_carrier_ok() handling in ixgbe_xmit_zc()
authorMaciej Fijalkowski <maciej.fijalkowski@intel.com>
Wed, 2 Mar 2022 17:59:27 +0000 (09:59 -0800)
committerPaolo Pisati <paolo.pisati@canonical.com>
Wed, 9 Mar 2022 14:17:54 +0000 (15:17 +0100)
commit9a67fbf34040a11c92ac8248b88f1814ea26d96f
treecbc1176d8746b0092c9b536c16d265a4665ec105
parent4f18873a7da9f8bd78ebb777f58e8079b9a0f22f
ixgbe: xsk: change !netif_carrier_ok() handling in ixgbe_xmit_zc()

BugLink: https://bugs.launchpad.net/bugs/1964361
commit 6c7273a266759d9d36f7c862149f248bcdeddc0f upstream.

Commit c685c69fba71 ("ixgbe: don't do any AF_XDP zero-copy transmit if
netif is not OK") addressed the ring transient state when
MEM_TYPE_XSK_BUFF_POOL was being configured which in turn caused the
interface to through down/up. Maurice reported that when carrier is not
ok and xsk_pool is present on ring pair, ksoftirqd will consume 100% CPU
cycles due to the constant NAPI rescheduling as ixgbe_poll() states that
there is still some work to be done.

To fix this, do not set work_done to false for a !netif_carrier_ok().

Fixes: c685c69fba71 ("ixgbe: don't do any AF_XDP zero-copy transmit if netif is not OK")
Reported-by: Maurice Baijens <maurice.baijens@ellips.com>
Tested-by: Maurice Baijens <maurice.baijens@ellips.com>
Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Tested-by: Sandeep Penigalapati <sandeep.penigalapati@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c