]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
ASoC: rsnd: don't fallback to PIO mode when -EPROBE_DEFER
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Thu, 6 Sep 2018 03:21:47 +0000 (03:21 +0000)
committerJuerg Haefliger <juergh@canonical.com>
Wed, 24 Jul 2019 01:53:31 +0000 (19:53 -0600)
commit9a78f73d55ada9fae19bc5df46fdd23b7b81afc4
treeec13a76846aff82361f53feebfd6177e81315af1
parenta8d055c2296d5a1a06c8fdeec2424ccd84cbe710
ASoC: rsnd: don't fallback to PIO mode when -EPROBE_DEFER

BugLink: https://bugs.launchpad.net/bugs/1836426
[ Upstream commit 6c92d5a2744e27619a8fcc9d74b91ee9f1cdebd1 ]

Current rsnd driver will fallback to PIO mode if it can't get DMA
handler. But, DMA might return -EPROBE_DEFER when probe timing.
This driver always fallback to PIO mode especially from
commit ac6bbf0cdf4206c ("iommu: Remove IOMMU_OF_DECLARE") because
of this reason.

The DMA driver will be probed later, but sound driver might be
probed as PIO mode in such case. This patch fixup this issue.
Then, -EPROBE_DEFER is not error. Thus, let's don't indicate error
message in such case.
And it needs to call rsnd_adg_remove() individually if probe failed,
because it registers clk which should be unregister.

Maybe PIO fallback feature itself is not needed,
but let's keep it so far.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
sound/soc/sh/rcar/core.c
sound/soc/sh/rcar/dma.c