]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
Partial revert "e1000e: Avoid receiver overrun interrupt bursts"
authorBenjamin Poirier <bpoirier@suse.com>
Thu, 8 Feb 2018 06:47:12 +0000 (15:47 +0900)
committerJuerg Haefliger <juergh@canonical.com>
Wed, 24 Jul 2019 01:49:32 +0000 (19:49 -0600)
commit9a8954dac40baa1fe070b9f660600a9b9b92e51d
tree953df544d70b19403c6d8427cf687735d66b933d
parent1d96d794faf31829bf3ad5ed620fcf6682106616
Partial revert "e1000e: Avoid receiver overrun interrupt bursts"

BugLink: https://bugs.launchpad.net/bugs/1836117
commit 1f0ea19722ef9dfa229a9540f70b8d1c34a98a6a upstream.

This partially reverts commit 4aea7a5c5e940c1723add439f4088844cd26196d.

We keep the fix for the first part of the problem (1) described in the log
of that commit, that is to read ICR in the other interrupt handler. We
remove the fix for the second part of the problem (2), Other interrupt
throttling.

Bursts of "Other" interrupts may once again occur during rxo (receive
overflow) traffic conditions. This is deemed acceptable in the interest of
avoiding unforeseen fallout from changes that are not strictly necessary.
As discussed, the e1000e driver should be in "maintenance mode".

Link: https://www.spinics.net/lists/netdev/msg480675.html
Signed-off-by: Benjamin Poirier <bpoirier@suse.com>
Acked-by: Alexander Duyck <alexander.h.duyck@intel.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
drivers/net/ethernet/intel/e1000e/netdev.c