]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
rtc: vr41xx: fix possible race condition
authorAlexandre Belloni <alexandre.belloni@bootlin.com>
Thu, 17 May 2018 20:47:05 +0000 (22:47 +0200)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Thu, 17 May 2018 20:54:19 +0000 (22:54 +0200)
commit9a99247c9c1d1c95c6e8153d013979aac6111c6e
tree6b4b17e2938b65b13741360d4465b3db146e5b0d
parent94389b28ba6c03eecf45105026c1f9978481a706
rtc: vr41xx: fix possible race condition

The probe function is not allowed to fail after the RTC is registered
because the following may happen:

CPU0:                                CPU1:
sys_load_module()
 do_init_module()
  do_one_initcall()
   cmos_do_probe()
    rtc_device_register()
     __register_chrdev()
     cdev->owner = struct module*
                                     open("/dev/rtc0")
    rtc_device_unregister()
  module_put()
  free_module()
   module_free(mod->module_core)
   /* struct module *module is now
      freed */
                                      chrdev_open()
                                       spin_lock(cdev_lock)
                                       cdev_get()
                                        try_module_get()
                                         module_is_live()
                                         /* dereferences already
                                            freed struct module* */

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-vr41xx.c