]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
net: vrf: Fix dst reference counting
authorDavid Ahern <dsa@cumulusnetworks.com>
Thu, 7 Apr 2016 18:10:06 +0000 (11:10 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 11 Apr 2016 19:56:20 +0000 (15:56 -0400)
commit9ab179d83b4e31ea277a123492e419067c2f129a
treed56d2138f40f62e348dd7ac0c0b6a70b4a3b9207
parent10c3c02255124e28c8bb63a274a543ee7e77f223
net: vrf: Fix dst reference counting

Vivek reported a kernel exception deleting a VRF with an active
connection through it. The root cause is that the socket has a cached
reference to a dst that is destroyed. Converting the dst_destroy to
dst_release and letting proper reference counting kick in does not
work as the dst has a reference to the device which needs to be released
as well.

I talked to Hannes about this at netdev and he pointed out the ipv4 and
ipv6 dst handling has dst_ifdown for just this scenario. Rather than
continuing with the reinvented dst wheel in VRF just remove it and
leverage the ipv4 and ipv6 versions.

Fixes: 193125dbd8eb2 ("net: Introduce VRF device driver")
Fixes: 35402e3136634 ("net: Add IPv6 support to VRF device")
Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/vrf.c
include/net/ip6_route.h
include/net/route.h
net/ipv4/route.c
net/ipv6/route.c