]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
iwlwifi: don't throw error when trying to remove IGTK
authorLuca Coelho <luciano.coelho@intel.com>
Fri, 31 Jan 2020 13:45:25 +0000 (15:45 +0200)
committerKhalid Elmously <khalid.elmously@canonical.com>
Fri, 13 Mar 2020 04:31:00 +0000 (00:31 -0400)
commit9ae2aa310a370fe292a26d2b44656b2e8a1ecad0
treee549d86090a4c16d683ad599b84de1d4e307d063
parent973e7bc73dcc1d3742003bf9cecf161662e50156
iwlwifi: don't throw error when trying to remove IGTK

BugLink: https://bugs.launchpad.net/bugs/1866678
commit 197288d5ba8a5289f22d3aeb4fca3824bfd9b4af upstream.

The IGTK keys are only removed by mac80211 after it has already
removed the AP station.  This causes the driver to throw an error
because mac80211 is trying to remove the IGTK when the station doesn't
exist anymore.

The firmware is aware that the station has been removed and can deal
with it the next time we try to add an IGTK for a station, so we
shouldn't try to remove the key if the station ID is
IWL_MVM_INVALID_STA.  Do this by removing the check for mvm_sta before
calling iwl_mvm_send_sta_igtk() and check return from that function
gracefully if the station ID is invalid.

Cc: stable@vger.kernel.org # 4.12+
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/net/wireless/intel/iwlwifi/mvm/sta.c