]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit
mmc: pxamci: fix potential oops
authorRobert Jarzmik <robert.jarzmik@free.fr>
Thu, 14 Jul 2016 15:05:50 +0000 (17:05 +0200)
committerSeth Forshee <seth.forshee@canonical.com>
Thu, 20 Oct 2016 13:06:54 +0000 (08:06 -0500)
commit9aeb52f9a6b28d39628546e1b1c8224683c91006
tree69248efec371dc06e8931ec2427dee9cef04dfc2
parent770c7e1329851cabb48953b8ae97b667a716d9c6
mmc: pxamci: fix potential oops

BugLink: http://bugs.launchpad.net/bugs/1631468
commit b3802db5eb72d2a96f4aa4ff0abb937033df2acf upstream.

As reported by Dan in his report in [1], there is a potential NULL
pointer derefence if these conditions are met :
 - there is no platform_data provided, ie. host->pdata = NULL

Fix this by only using the platform data ro_invert when a gpio for
read-only is provided by the platform data.

This doesn't appear yet as every pxa board provides a platform_data, and
calls pxa_set_mci_info() with a non NULL pointer.

[1] [bug report] mmc: pxamci: fix card detect with slot-gpio API.
The commit fd546ee6a7dc ("mmc: pxamci: fix card detect with slot-gpio
API") from Sep 26, 2015, leads to the following static checker warning:

drivers/mmc/host/pxamci.c:809 pxamci_probe()
warn: variable dereferenced before check 'host->pdata' (see line 798)

Fixes: fd546ee6a7dc ("mmc: pxamci: fix card detect with slot-gpio API")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
drivers/mmc/host/pxamci.c