]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
dm thin metadata: do not allow the data block size to change
authorMike Snitzer <snitzer@redhat.com>
Mon, 14 Jul 2014 20:35:54 +0000 (16:35 -0400)
committerMike Snitzer <snitzer@redhat.com>
Tue, 15 Jul 2014 18:05:26 +0000 (14:05 -0400)
commit9aec8629ec829fc9403788cd959e05dd87988bd1
tree16ef5465ee0b354f266fcdec89240f64212ef622
parent7a7a3b45fed9a144dbf766ee842a4c5d0632b81d
dm thin metadata: do not allow the data block size to change

The block size for the thin-pool's data device must remained fixed for
the life of the thin-pool.  Disallow any attempt to change the
thin-pool's data block size.

It should be noted that attempting to change the data block size via
thin-pool table reload will be ignored as a side-effect of the thin-pool
handover that the thin-pool target does during thin-pool table reload.

Here is an example outcome of attempting to load a thin-pool table that
reduced the thin-pool's data block size from 1024K to 512K.

Before:
kernel: device-mapper: thin: 253:4: growing the data device from 204800 to 409600 blocks

After:
kernel: device-mapper: thin metadata: changing the data block size (from 2048 to 1024) is not supported
kernel: device-mapper: table: 253:4: thin-pool: Error creating metadata object
kernel: device-mapper: ioctl: error adding target to table

Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Acked-by: Joe Thornber <ejt@redhat.com>
Cc: stable@vger.kernel.org
drivers/md/dm-thin-metadata.c