]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
kobject: fix suppressing modalias in uevents delivered over netlink
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 13 Dec 2017 23:21:22 +0000 (15:21 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 21 Dec 2017 10:10:33 +0000 (11:10 +0100)
commit9b3fa47d4a76b1d606a396455f9bbeee083ef008
tree8fe11ace9a6ce42159bc38aa287082706d1cfc85
parentf57ab9a01a36ef3454333251cc57e3a9948b17bf
kobject: fix suppressing modalias in uevents delivered over netlink

The commit 4a336a23d619 ("kobject: copy env blob in one go") optimized
constructing uevent data for delivery over netlink by using the raw
environment buffer, instead of reconstructing it from individual
environment pointers. Unfortunately in doing so it broke suppressing
MODALIAS attribute for KOBJ_UNBIND events, as the code that suppressed this
attribute only adjusted the environment pointers, but left the buffer
itself alone. Let's fix it by making sure the offending attribute is
obliterated form the buffer as well.

Reported-by: Tariq Toukan <tariqt@mellanox.com>
Reported-by: Casey Leedom <leedom@chelsio.com>
Fixes: 4a336a23d619 ("kobject: copy env blob in one go")
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
lib/kobject_uevent.c