]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
net: Fix unwanted sign extension in netdev_stats_to_stats64()
authorFelix Riemann <felix.riemann@sma.de>
Fri, 10 Feb 2023 12:36:44 +0000 (13:36 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 13 Feb 2023 09:53:25 +0000 (09:53 +0000)
commit9b55d3f0a69af649c62cbc2633e6d695bb3cc583
tree58706818f76fa04d27f5c8523537021bcc6d3dea
parentc68f345b7c425b38656e1791a0486769a8797016
net: Fix unwanted sign extension in netdev_stats_to_stats64()

When converting net_device_stats to rtnl_link_stats64 sign extension
is triggered on ILP32 machines as 6c1c509778 changed the previous
"ulong -> u64" conversion to "long -> u64" by accessing the
net_device_stats fields through a (signed) atomic_long_t.

This causes for example the received bytes counter to jump to 16EiB after
having received 2^31 bytes. Casting the atomic value to "unsigned long"
beforehand converting it into u64 avoids this.

Fixes: 6c1c5097781f ("net: add atomic_long_t to net_device_stats fields")
Signed-off-by: Felix Riemann <felix.riemann@sma.de>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/dev.c