]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
net: phy: mdio-bcm-unimac: fix potential NULL dereference in unimac_mdio_probe()
authorWei Yongjun <weiyongjun1@huawei.com>
Fri, 16 Mar 2018 10:47:54 +0000 (18:47 +0800)
committerThadeu Lima de Souza Cascardo <cascardo@canonical.com>
Fri, 16 Mar 2018 11:32:21 +0000 (08:32 -0300)
commit9b9e34b03bf7e6cf25d4e279a969bc5edef5fdd5
treecad891d80bc7d83ae470edb80ab41a151e8f42ca
parent3e7dbceab543778d17a717fa0db18c63529a850f
net: phy: mdio-bcm-unimac: fix potential NULL dereference in unimac_mdio_probe()

CVE-2018-8043

platform_get_resource() may fail and return NULL, so we should
better check it's return value to avoid a NULL pointer dereference
a bit later in the code.

This is detected by Coccinelle semantic patch.

@@
expression pdev, res, n, t, e, e1, e2;
@@

res = platform_get_resource(pdev, t, n);
+ if (!res)
+   return -EINVAL;
... when != res == NULL
e = devm_ioremap(e1, res->start, e2);

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit 297a6961ffb8ff4dc66c9fbf53b924bd1dda05d5)
Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
drivers/net/phy/mdio-bcm-unimac.c