]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
net: stmmac: dwmac-qcom-ethqos: fix a regression on EMAC < 3
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Fri, 2 Jun 2023 19:04:55 +0000 (21:04 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 5 Jun 2023 10:38:49 +0000 (11:38 +0100)
commit9bc009734774549f8bb8d7e526ba10e70d751a7c
tree073d62e8ebe0d59d932b1ee0a02f90019a54edad
parentd753693101881b9c17f04edc365cf6685c475ff1
net: stmmac: dwmac-qcom-ethqos: fix a regression on EMAC < 3

We must not assign plat_dat->dwmac4_addrs unconditionally as for
structures which don't set them, this will result in the core driver
using zeroes everywhere and breaking the driver for older HW. On EMAC < 2
the address should remain NULL.

Fixes: b68376191c69 ("net: stmmac: dwmac-qcom-ethqos: Add EMAC3 support")
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Andrew Halaney <ahalaney@redhat.com>
Reviewed-by: Siddharth Vadapalli <s-vadapalli@ti.com>
Reviewed-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c