]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
dmaengine: ti: k3-udma-private: Fix refcount leak bug in of_xudma_dev_get()
authorLiang He <windhl@126.com>
Wed, 20 Jul 2022 07:32:34 +0000 (15:32 +0800)
committerStefan Bader <stefan.bader@canonical.com>
Wed, 23 Nov 2022 14:11:41 +0000 (15:11 +0100)
commit9c0eafe25fd9895bc9b56ea88030bcb76d4fd0e9
treed64381f9bd6559225bfa0779a3d2590b4ba9d532
parenta2f9db814f09e600621ced21fbe8d0f5cce9b79c
dmaengine: ti: k3-udma-private: Fix refcount leak bug in of_xudma_dev_get()

BugLink: https://bugs.launchpad.net/bugs/1995420
[ Upstream commit f9fdb0b86f087c2b7f6c6168dd0985a3c1eda87e ]

We should call of_node_put() for the reference returned by
of_parse_phandle() in fail path or when it is not used anymore.
Here we only need to move the of_node_put() before the check.

Fixes: d70241913413 ("dmaengine: ti: k3-udma: Add glue layer for non DMAengine users")
Signed-off-by: Liang He <windhl@126.com>
Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>
Link: https://lore.kernel.org/r/20220720073234.1255474-1-windhl@126.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/dma/ti/k3-udma-private.c