]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
virtio-blk: Don't use MAX_DISCARD_SEGMENTS if max_discard_seg is zero
authorXie Yongji <xieyongji@bytedance.com>
Fri, 4 Mar 2022 10:00:57 +0000 (18:00 +0800)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 20 May 2022 13:17:41 +0000 (15:17 +0200)
commit9c29c12dd06d71712905fdb4cf9951849aee2d9f
treee48b174ce3e2c5f9a025b14afb72bf0140fe7b64
parentba93d10eacd07b79c4c41f2ff43659411333c2d4
virtio-blk: Don't use MAX_DISCARD_SEGMENTS if max_discard_seg is zero

BugLink: https://bugs.launchpad.net/bugs/1969672
[ Upstream commit dacc73ed0b88f1a787ec20385f42ca9dd9eddcd0 ]

Currently the value of max_discard_segment will be set to
MAX_DISCARD_SEGMENTS (256) with no basis in hardware if device
set 0 to max_discard_seg in configuration space. It's incorrect
since the device might not be able to handle such large descriptors.
To fix it, let's follow max_segments restrictions in this case.

Fixes: 1f23816b8eb8 ("virtio_blk: add discard and write zeroes support")
Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
Link: https://lore.kernel.org/r/20220304100058.116-1-xieyongji@bytedance.com
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/block/virtio_blk.c