]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
arm64: kexec: Fix missing error code 'ret' warning in load_other_segments()
authorLakshmi Ramasubramanian <nramas@linux.microsoft.com>
Fri, 10 Dec 2021 01:01:21 +0000 (17:01 -0800)
committerCatalin Marinas <catalin.marinas@arm.com>
Thu, 16 Dec 2021 17:44:58 +0000 (17:44 +0000)
commit9c5d89bc10551f1aecd768b00fca3339a7b8c8ee
treedbefcc5f79ca9d8d1c53b07ff5fd7bfced44468f
parent35b6b28e69985eafb20b3b2c7bd6eca452b56b53
arm64: kexec: Fix missing error code 'ret' warning in load_other_segments()

Since commit ac10be5cdbfa ("arm64: Use common
of_kexec_alloc_and_setup_fdt()"), smatch reports the following warning:

  arch/arm64/kernel/machine_kexec_file.c:152 load_other_segments()
  warn: missing error code 'ret'

Return code is not set to an error code in load_other_segments() when
of_kexec_alloc_and_setup_fdt() call returns a NULL dtb. This results
in status success (return code set to 0) being returned from
load_other_segments().

Set return code to -EINVAL if of_kexec_alloc_and_setup_fdt() returns
NULL dtb.

Signed-off-by: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: ac10be5cdbfa ("arm64: Use common of_kexec_alloc_and_setup_fdt()")
Link: https://lore.kernel.org/r/20211210010121.101823-1-nramas@linux.microsoft.com
Signed-off-by: Will Deacon <will@kernel.org>
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
arch/arm64/kernel/machine_kexec_file.c