]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
netpoll: Remove dead packet receive code (CONFIG_NETPOLL_TRAP)
authorEric W. Biederman <ebiederm@xmission.com>
Sat, 15 Mar 2014 03:51:52 +0000 (20:51 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 17 Mar 2014 19:48:12 +0000 (15:48 -0400)
commit9c62a68d13119a1ca9718381d97b0cb415ff4e9d
treeaae7c0ffaa451dc44afbbba9c37780e9c12bd1fc
parente1bd4d3d7dd2a4a0e731ffe07c439927c23f16ea
netpoll: Remove dead packet receive code (CONFIG_NETPOLL_TRAP)

The netpoll packet receive code only becomes active if the netpoll
rx_skb_hook is implemented, and there is not a single implementation
of the netpoll rx_skb_hook in the kernel.

All of the out of tree implementations I have found all call
netpoll_poll which was removed from the kernel in 2011, so this
change should not add any additional breakage.

There are problems with the netpoll packet receive code.  __netpoll_rx
does not call dev_kfree_skb_irq or dev_kfree_skb_any in hard irq
context.  netpoll_neigh_reply leaks every skb it receives.  Reception
of packets does not work successfully on stacked devices (aka bonding,
team, bridge, and vlans).

Given that the netpoll packet receive code is buggy, there are no
out of tree users that will be merged soon, and the code has
not been used for in tree for a decade let's just remove it.

Reverting this commit can server as a starting point for anyone
who wants to resurrect netpoll packet reception support.

Acked-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/Kconfig
include/linux/netdevice.h
include/linux/netpoll.h
net/core/dev.c
net/core/netpoll.c