]> git.proxmox.com Git - mirror_qemu.git/commit
pc-bios/s390-ccw: enable subchannel for IPL I/O devices
authorDong Jia Shi <bjsdjshi@linux.vnet.ibm.com>
Thu, 22 Sep 2016 08:36:39 +0000 (10:36 +0200)
committerChristian Borntraeger <borntraeger@de.ibm.com>
Wed, 28 Sep 2016 11:24:51 +0000 (13:24 +0200)
commit9c9f5f311a4b391c2dba57cf06b63d62b790e891
treecec0f393587b48495c3ee30e0bae230ca2ba9d78
parentf9530c32420fff941b7bc8bb5d90310eecab5a96
pc-bios/s390-ccw: enable subchannel for IPL I/O devices

IPL should cause the IPL I/O device to become enabled. So when handling
the IPL program, we should set the E (Enable) bit. However, virtio-ccw
does not know whether it's dealing with an IPL device or not. Since
trying to perform I/O on a disabled device doesn't make any sense,
let's just always enable it. At the same time we can remove the
SCSW_FCTL_START_FUNC flag as it is ignored for msch anyway and did
not enable the device as intended.

Reported-by: Farhan Ali <alifm@linux.vnet.ibm.com>
Signed-off-by: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Reviewed-by: Sascha Silbe <silbe@linux.vnet.ibm.com>
Signed-off-by: Halil Pasic <pasic@linux.vnet.ibm.com>
[remove superfluous flag]
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
pc-bios/s390-ccw/virtio.c