]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
dp83640: don't recieve time stamps twice
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 18 Apr 2017 19:14:26 +0000 (22:14 +0300)
committerDavid S. Miller <davem@davemloft.net>
Thu, 20 Apr 2017 20:00:48 +0000 (16:00 -0400)
commit9d386cd9a755c8293e8916264d4d053878a7c9c7
treeb9a9002e3a57af7b77a56507baacbc0da9a2de43
parent2f3bb64247b5b083d05ccecad9c2e139bbfdc294
dp83640: don't recieve time stamps twice

This patch is prompted by a static checker warning about a potential
use after free.  The concern is that netif_rx_ni() can free "skb" and we
call it twice.

When I look at the commit that added this, it looks like some stray
lines were added accidentally.  It doesn't make sense to me that we
would recieve the same data two times.  I asked the author but never
recieved a response.

I can't test this code, but I'm pretty sure my patch is correct.

Fixes: 4b063258ab93 ("dp83640: Delay scheduled work.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Stefan Sørensen <stefan.sorensen@spectralink.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/dp83640.c