]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
PCI: pciehp: Report power fault only once until we clear it
authorKeith Busch <keith.busch@intel.com>
Tue, 1 Aug 2017 07:11:52 +0000 (03:11 -0400)
committerSeth Forshee <seth.forshee@canonical.com>
Thu, 28 Sep 2017 14:34:57 +0000 (10:34 -0400)
commit9d5f03901af78612ceb4b751bd97a456a18937c4
treeb40bf224db88ad4aa2325c3bed8075e2d98a2d93
parent423cbedb12f2ee42506b4243514ae51f225eda2e
PCI: pciehp: Report power fault only once until we clear it

BugLink: http://bugs.launchpad.net/bugs/1720154
commit 7612b3b28c0b900dcbcdf5e9b9747cc20a1e2455 upstream.

When a power fault occurs, the power controller sets Power Fault Detected
in the Slot Status register, and pciehp_isr() queues an INT_POWER_FAULT
event to handle it.

It also clears Power Fault Detected, but since nothing has yet changed to
correct the power fault, the power controller will likely set it again
immediately, which may cause an infinite loop when pcie_isr() rechecks
Slot Status.

Fix that by masking off Power Fault Detected from new events if the driver
hasn't seen the power fault clear from the previous handling attempt.

Fixes: fad214b0aa72 ("PCI: pciehp: Process all hotplug events before looking for new ones")
Signed-off-by: Keith Busch <keith.busch@intel.com>
[bhelgaas: changelog, pull test out and add comment]
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Mayurkumar Patel <mayurkumar.patel@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
drivers/pci/hotplug/pciehp_hpc.c