]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
ALSA: hda/hdmi: Cancel pending works before suspend
authorTakashi Iwai <tiwai@suse.de>
Wed, 10 Mar 2021 11:28:09 +0000 (12:28 +0100)
committerSeth Forshee <seth.forshee@canonical.com>
Wed, 17 Mar 2021 18:39:55 +0000 (13:39 -0500)
commit9d78ebbe267675658e1cd6cb44f8804bfd1de2d7
tree65d3b45769a7d1cdddae55f2887acd331d0ca63a
parent1bef250afef0a46e89112e18bbfd3a862ffd4a26
ALSA: hda/hdmi: Cancel pending works before suspend

BugLink: https://bugs.launchpad.net/bugs/1919492
commit eea46a0879bcca23e15071f9968c0f6e6596e470 upstream.

The per_pin->work might be still floating at the suspend, and this may
hit the access to the hardware at an unexpected timing.  Cancel the
work properly at the suspend callback for avoiding the buggy access.

Note that the bug doesn't trigger easily in the recent kernels since
the work is queued only when the repoll count is set, and usually it's
only at the resume callback, but it's still possible to hit in
theory.

BugLink: https://bugzilla.suse.com/show_bug.cgi?id=1182377
Reported-and-tested-by: Abhishek Sahu <abhsahu@nvidia.com>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20210310112809.9215-4-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
sound/pci/hda/patch_hdmi.c