]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
ALSA: memalloc: Try dma_alloc_noncontiguous() at first
authorTakashi Iwai <tiwai@suse.de>
Sat, 12 Nov 2022 08:47:18 +0000 (09:47 +0100)
committerTakashi Iwai <tiwai@suse.de>
Sat, 12 Nov 2022 08:48:51 +0000 (09:48 +0100)
commit9d8e536d36e75e76614fe09ffab9a1df95b8b666
treedfc3999923e3facea7df340060046d41e01dfe15
parent9a5523f72bd2b0d66eef3d58810c6eb7b5ffc143
ALSA: memalloc: Try dma_alloc_noncontiguous() at first

The latest fix for the non-contiguous memalloc helper changed the
allocation method for a non-IOMMU system to use only the fallback
allocator.  This should have worked, but it caused a problem sometimes
when too many non-contiguous pages are allocated that can't be treated
by HD-audio controller.

As a quirk workaround, go back to the original strategy: use
dma_alloc_noncontiguous() at first, and apply the fallback only when
it fails, but only for non-IOMMU case.

We'll need a better fix in the fallback code as well, but this
workaround should paper over most cases.

Fixes: 9736a325137b ("ALSA: memalloc: Don't fall back for SG-buffer with IOMMU")
Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Link: https://lore.kernel.org/r/CAHk-=wgSH5ubdvt76gNwa004ooZAEJL_1Q-Fyw5M2FDdqL==dg@mail.gmail.com
Link: https://lore.kernel.org/r/20221112084718.3305-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/memalloc.c