]> git.proxmox.com Git - mirror_qemu.git/commit
os: don't corrupt pre-existing memory-backend data with prealloc
authorDaniel P. Berrange <berrange@redhat.com>
Fri, 3 Mar 2017 11:32:55 +0000 (11:32 +0000)
committerStefan Hajnoczi <stefanha@redhat.com>
Wed, 15 Mar 2017 03:55:41 +0000 (11:55 +0800)
commit9dc44aa5829eb3131a01378a738dee28a382bbc1
tree7626e5cbbd351029d49c269a4291b60540beba1e
parentd84f714eafedd8bb9d4aaec8b76417bef8e3535e
os: don't corrupt pre-existing memory-backend data with prealloc

When using a memory-backend object with prealloc turned on, QEMU
will memset() the first byte in every memory page to zero. While
this might have been acceptable for memory backends associated
with RAM, this corrupts application data for NVDIMMs.

Instead of setting every page to zero, read the current byte
value and then just write that same value back, so we are not
corrupting the original data. Directly write the value instead
of memset()ing it, since there's no benefit to memset for a
single byte write.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Reviewed-by: Andrea Arcangeli <aarcange@redhat.com>
Message-id: 20170303113255.28262-1-berrange@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
util/oslib-posix.c