]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
irqchip/alpine-msi: Fix freeing of interrupts on allocation error path
authorMarc Zyngier <maz@kernel.org>
Sun, 29 Nov 2020 13:55:25 +0000 (13:55 +0000)
committerPaolo Pisati <paolo.pisati@canonical.com>
Mon, 4 Jan 2021 15:37:32 +0000 (16:37 +0100)
commit9e128dadca5ae01804a784b7f35c4c4a820be562
tree7fd18ab6f89572cb4fb7f5a4e09fd4a5717f3ebd
parent88bdd020ae714a6578839ba4ed33dd039320ba71
irqchip/alpine-msi: Fix freeing of interrupts on allocation error path

BugLink: https://bugs.launchpad.net/bugs/1910111
[ Upstream commit 3841245e8498a789c65dedd7ffa8fb2fee2c0684 ]

The alpine-msi driver has an interesting allocation error handling,
where it frees the same interrupts repeatedly. Hilarity follows.

This code is probably never executed, but let's fix it nonetheless.

Fixes: e6b78f2c3e14 ("irqchip: Add the Alpine MSIX interrupt controller")
Signed-off-by: Marc Zyngier <maz@kernel.org>
Reviewed-by: Antoine Tenart <atenart@kernel.org>
Cc: Tsahee Zidenberg <tsahee@annapurnalabs.com>
Cc: Antoine Tenart <atenart@kernel.org>
Link: https://lore.kernel.org/r/20201129135525.396671-1-maz@kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
drivers/irqchip/irq-alpine-msi.c