]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
drm/i915: compile-time consistency check on __EXEC_OBJECT flags
authorDave Gordon <david.s.gordon@intel.com>
Thu, 14 Jul 2016 13:52:03 +0000 (14:52 +0100)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 19 Jul 2016 07:06:16 +0000 (09:06 +0200)
commit9e2793f6e4e2ca452457e459f013cc8e6b08a789
tree527d508c6959e5b950bb4a5ed161b06ab946882b
parenta87848750ebc2c174879f5acaa1183044287fd03
drm/i915: compile-time consistency check on __EXEC_OBJECT flags

Two different sets of flag bits are stored in the 'flags' member of a
'struct drm_i915_gem_exec_object2', and they're defined in two different
source files, increasing the risk of an accidental clash.

Some flags in this field are supplied by the user; these are defined in
i915_drm.h, and they start from the LSB and work up.

Other flags are defined in i915_gem_execbuffer, for internal use within
that file only; they start from the MSB and work down.

So here we add a compile-time check that the two sets of flags do not
overlap, which would cause all sorts of confusion.

Signed-off-by: Dave Gordon <david.s.gordon@intel.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/1468504324-12690-1-git-send-email-david.s.gordon@intel.com
drivers/gpu/drm/i915/i915_gem_execbuffer.c
include/uapi/drm/i915_drm.h