]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
ring-buffer: Do not update before stamp when switching sub-buffers
authorSteven Rostedt (Google) <rostedt@goodmis.org>
Mon, 11 Dec 2023 16:44:20 +0000 (11:44 -0500)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Wed, 13 Dec 2023 01:55:45 +0000 (20:55 -0500)
commit9e45e39dc249c970d99d2681f6bcb55736fd725c
treeaa4d7754a0d1bc98e364d463f156b00091f631d8
parentd06aff1cb13d2a0d52b48e605462518149c98c81
ring-buffer: Do not update before stamp when switching sub-buffers

The ring buffer timestamps are synchronized by two timestamp placeholders.
One is the "before_stamp" and the other is the "write_stamp" (sometimes
referred to as the "after stamp" but only in the comments. These two
stamps are key to knowing how to handle nested events coming in with a
lockless system.

When moving across sub-buffers, the before stamp is updated but the write
stamp is not. There's an effort to put back the before stamp to something
that seems logical in case there's nested events. But as the current event
is about to cross sub-buffers, and so will any new nested event that happens,
updating the before stamp is useless, and could even introduce new race
conditions.

The first event on a sub-buffer simply uses the sub-buffer's timestamp
and keeps a "delta" of zero. The "before_stamp" and "write_stamp" are not
used in the algorithm in this case. There's no reason to try to fix the
before_stamp when this happens.

As a bonus, it removes a cmpxchg() when crossing sub-buffers!

Link: https://lore.kernel.org/linux-trace-kernel/20231211114420.36dde01b@gandalf.local.home
Cc: stable@vger.kernel.org
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Fixes: a389d86f7fd09 ("ring-buffer: Have nested events still record running time stamp")
Reviewed-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
kernel/trace/ring_buffer.c