]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
mlxsw: spectrum_router: Use struct_size() in kzalloc()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Fri, 8 Feb 2019 03:42:41 +0000 (21:42 -0600)
committerDavid S. Miller <davem@davemloft.net>
Sat, 9 Feb 2019 06:57:28 +0000 (22:57 -0800)
commit9e475293cd40fc9c14de63c53b5754f06007059d
tree1bc56da7779c47227bf6b8d2c7a56e41f80a47d6
parent370600afdd2e33665c84d06f34e7c223d5379b4a
mlxsw: spectrum_router: Use struct_size() in kzalloc()

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct foo {
    int stuff;
    struct boo entry[];
};

size = sizeof(struct foo) + count * sizeof(struct boo);
instance = kzalloc(size, GFP_KERNEL)

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL)

Notice that, in this case, variable alloc_size is not necessary, hence
it is removed.

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c