]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
"xfs: fix error handling for synchronous writes" revisited
authorAjeet Yadav <ajeet.yadav.77@gmail.com>
Fri, 29 Jul 2011 07:42:59 +0000 (07:42 +0000)
committerAlex Elder <aelder@sgi.com>
Wed, 10 Aug 2011 22:00:21 +0000 (17:00 -0500)
commit9e978d8f7db1c5de7cdc6450a8ca208db3b95f84
tree728a04a500acc62e49c944cb46096d651daf0d41
parente44f4112a46ca817fe2758aac7bf7893a64a8c0e
"xfs: fix error handling for synchronous writes" revisited

xfs: fix for hang during synchronous buffer write error

If removed storage while synchronous buffer write underway,
"xfslogd" hangs.

Detailed log http://oss.sgi.com/archives/xfs/2011-07/msg00740.html

Related work bfc60177f8ab509bc225becbb58f7e53a0e33e81
"xfs: fix error handling for synchronous writes"

Given that xfs_bwrite actually does the shutdown already after
waiting for the b_iodone completion and given that we actually
found that calling xfs_force_shutdown from inside
xfs_buf_iodone_callbacks was a major contributor the problem
it better to drop this call.

Signed-off-by: Ajeet Yadav <ajeet.yadav.77@gmail.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Alex Elder <aelder@sgi.com>
fs/xfs/xfs_buf_item.c