]> git.proxmox.com Git - qemu.git/commit
block-migration: fix blk_mig_save_dirty_block() return value checking
authorStefan Hajnoczi <stefanha@redhat.com>
Sun, 10 Feb 2013 22:12:45 +0000 (23:12 +0100)
committerAnthony Liguori <aliguori@us.ibm.com>
Mon, 11 Feb 2013 14:14:04 +0000 (08:14 -0600)
commit9ee0cb201e6bfe03549a649fd165a85cfed34d05
tree99bd3cd827fe1db30307b7c9c1a73e7ba4a8c831
parentd5f1f286ef8c7c96614779a40af724d7109175d5
block-migration: fix blk_mig_save_dirty_block() return value checking

Commit 43be3a25c931a7f61a76fbfc9d35584cbfc5fb58 changed the
blk_mig_save_dirty_block() return code handling.  The function's doc
comment says:

  /* return value:
   * 0: too much data for max_downtime
   * 1: few enough data for max_downtime
   */

Because of the 1 return value, callers must check for ret < 0 instead of
just:

  if (ret) { ... }

We do not want to bail when 1 is returned, only on error.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 1360534366-26723-3-git-send-email-stefanha@redhat.com
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
block-migration.c