]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
s390/qeth: fix error handling for isolation mode cmds
authorJulian Wiedmann <jwi@linux.ibm.com>
Wed, 17 Jun 2020 14:54:52 +0000 (16:54 +0200)
committerKhalid Elmously <khalid.elmously@canonical.com>
Sat, 8 Aug 2020 05:53:12 +0000 (01:53 -0400)
commit9f2d2a823b5dbc36919080bada1c2d6c6cc898a8
tree710cce9729d16a22635801eed54834d19f3a66db
parent3b2f0c87a866408443f026625d629c45afb9675c
s390/qeth: fix error handling for isolation mode cmds

BugLink: https://bugs.launchpad.net/bugs/1885942
[ Upstream commit e2dfcfba00ba4a414617ef4c5a8501fe21567eb3 ]

Current(?) OSA devices also store their cmd-specific return codes for
SET_ACCESS_CONTROL cmds into the top-level cmd->hdr.return_code.
So once we added stricter checking for the top-level field a while ago,
none of the error logic that rolls back the user's configuration to its
old state is applied any longer.

For this specific cmd, go back to the old model where we peek into the
cmd structure even though the top-level field indicated an error.

Fixes: 686c97ee29c8 ("s390/qeth: fix error handling in adapter command callbacks")
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>
drivers/s390/net/qeth_core_main.c