]> git.proxmox.com Git - mirror_qemu.git/commit
target/i386/monitor: Return QMP error when SEV is not enabled for guest
authorPhilippe Mathieu-Daudé <philmd@redhat.com>
Thu, 7 Oct 2021 16:16:59 +0000 (18:16 +0200)
committerPaolo Bonzini <pbonzini@redhat.com>
Wed, 13 Oct 2021 08:47:49 +0000 (10:47 +0200)
commit9f885cac701325ebcbf7e4393aa9b21b32ec3c12
tree38903becb92ad245606b337a5d490f4e224c7d4e
parent2c7233eb103adbf567778270b69950dd7a776c72
target/i386/monitor: Return QMP error when SEV is not enabled for guest

If the management layer tries to inject a secret, it gets an empty
response in case the guest doesn't have SEV enabled, or the binary
is built without SEV:

  { "execute": "sev-inject-launch-secret",
    "arguments": { "packet-header": "mypkt", "secret": "mypass", "gpa": 4294959104 }
  }
  {
      "return": {
      }
  }

Make it clearer by returning an error:

  { "execute": "sev-inject-launch-secret",
    "arguments": { "packet-header": "mypkt", "secret": "mypass", "gpa": 4294959104 }
  }
  {
      "error": {
          "class": "GenericError",
          "desc": "SEV not enabled for guest"
      }
  }

Note: we will remove the sev_inject_launch_secret() stub in few commits,
      so we don't bother to add error_setg() there.

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Connor Kuehl <ckuehl@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20211007161716.453984-7-philmd@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
target/i386/monitor.c